On Thu, May 06, 2021 at 06:09:54PM +0000, Sean Christopherson wrote: > On Thu, Apr 29, 2021, Dan Carpenter wrote: > > Hello Brijesh Singh, > > > > The patch d3d1af85e2c7: "KVM: SVM: Add KVM_SEND_UPDATE_DATA command" > > from Apr 15, 2021, leads to the following static checker warning: > > > > arch/x86/kvm/svm/sev.c:1268 sev_send_update_data() warn: 'guest_page' is an error pointer or valid > > arch/x86/kvm/svm/sev.c:1316 sev_send_update_data() warn: maybe return -EFAULT instead of the bytes remaining? > > arch/x86/kvm/svm/sev.c:1462 sev_receive_update_data() warn: 'guest_page' is an error pointer or valid > > Thanks for the report. Is the static checker you're using publicly available? > Catching these bugs via a checker is super cool! This is a Smatch check, but I'm glad you asked about this because it turns out I never committed the "is an error pointer or valid" check. I'll do that now and push it later today. regards, dan carpenter
