On Tue, May 04, 2021, Paolo Bonzini wrote: > On 04/05/21 22:13, Sean Christopherson wrote: > > > + /* > > > + * If set, the rmap should be allocated for any newly created or > > > + * modified memslots. If allocating rmaps lazily, this may be set > > > + * before the rmaps are allocated for existing memslots, but > > > + * shadow_mmu_active will not be set until after the rmaps are fully > > > + * allocated. > > > + */ > > > + bool alloc_memslot_rmaps; > > Maybe "need_rmaps" or "need_memslot_rmaps"? > > > > Since we're bikeshedding I prefer "memslots_have_rmaps" or something not too > distant from that. Works for me.