Re: [kvm-unit-tests PATCH] s390x: Fix vector stfle checks

[David Hildenbrand <david@xxxxxxxxxx>]

On 03.05.21 14:47, Janosch Frank wrote:
> 134 is for bcd
> 135 is for the vector enhancements
>
> Not the other way around...
>
> Signed-off-by: Janosch Frank <frankja@xxxxxxxxxxxxx>
> Suggested-by: David Hildenbrand <david@xxxxxxxxxx>
> ---
>   s390x/vector.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/s390x/vector.c b/s390x/vector.c
> index d1b6a571..b052de55 100644
> --- a/s390x/vector.c
> +++ b/s390x/vector.c
> @@ -53,7 +53,7 @@ static void test_add(void)
>   /* z14 vector extension test */
>   static void test_ext1_nand(void)
>   {
> -	bool has_vext = test_facility(134);
> +	bool has_vext = test_facility(135);
>   	static struct prm {
>   		__uint128_t a,b,c;
>   	} prm __attribute__((aligned(16)));
> @@ -79,7 +79,7 @@ static void test_ext1_nand(void)
>   /* z14 bcd extension test */
>   static void test_bcd_add(void)
>   {
> -	bool has_bcd = test_facility(135);
> +	bool has_bcd = test_facility(134);
>   	static struct prm {
>   		__uint128_t a,b,c;
>   	} prm __attribute__((aligned(16)));

Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>

thanks!

--
Thanks,

David / dhildenb