On 10/20/2009 07:02 PM, Chris Lalancette wrote:
get_desc_base() sign-extends because of some complicated u8 to unsigned rules that I'm not completely sure of. The below patch fixes my original issue, but I'm not at all sure that this is the right thing to do. I could also change get_desc_base() itself to do the casting, which should do the right thing for all callers, but I'm not sure if that's what all callers want. Anybody else have an opinion?
get_desc_base() is broken and should be fixed. No caller could possibly want this sign extension (64-bit segment bases are only possible using MSR_FS_BASE/MSR_GS_BASE/MSR_KERNEL_GS_BASE).
-- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html