On 29/04/21 18:22, Ben Gardon wrote:
On Wed, Apr 28, 2021 at 9:12 PM Kai Huang <kai.huang@xxxxxxxxx> wrote:
In kvm_tdp_mmu_map(), while iterating TDP MMU page table entries, it is
possible SPTE has already been frozen by another thread but the frozen
is not done yet, for instance, when another thread is still in middle of
zapping large page. In this case, the !is_shadow_present_pte() check
for old SPTE in tdp_mmu_for_each_pte() may hit true, and in this case
allocating new page table is unnecessary since tdp_mmu_set_spte_atomic()
later will return false and page table will need to be freed. Add
is_removed_spte() check before allocating new page table to avoid this.
Signed-off-by: Kai Huang <kai.huang@xxxxxxxxx>
Nice catch!
Reviewed-by: Ben Gardon <bgardon@xxxxxxxxxx>
Queued, thanks for the quick review.
Paolo
