On 4/26/21 11:26 AM, Jason Gunthorpe wrote: > On Fri, Apr 23, 2021 at 05:08:10PM -0700, Randy Dunlap wrote: >> On 4/23/21 4:02 PM, Jason Gunthorpe wrote: >>> @@ -171,7 +171,7 @@ config SAMPLE_VFIO_MDEV_MDPY_FB >>> >>> config SAMPLE_VFIO_MDEV_MBOCHS >>> tristate "Build VFIO mdpy example mediated device sample code -- loadable modules only" >> >> You can drop the ending of the prompt string. > > Hum, I see this whole sample kconfig file is filled with this '&& m' > pattern, I wonder if there is a reason? > > I think I will put the '&& m' back, I thought it was some kconfig > misunderstanding as it is very strange to see a naked '&& M'. It just limits those kconfig items to being =m or not set, i.e., even though they are tristate, setting to =y is not allowed. I guess the thinking is that samples don't need to reside in system memory for very long. However, if you want this one to be capable of =y, like your patch, you can still remove the end of the prompt string. -- ~Randy
