Hi Drew, On 4/22/21 5:12 PM, Andrew Jones wrote: > On Wed, Apr 21, 2021 at 08:40:55AM +0200, Andrew Jones wrote: >> On Tue, Apr 20, 2021 at 09:00:00PM +0200, Andrew Jones wrote: >>> + assert(mem.end); >>> assert(!(mem.start & ~PHYS_MASK) && !((mem.end - 1) & ~PHYS_MASK)); >> Eh, I promised Alex not to do this, but then didn't correct it quite >> right. This should be >> >> assert(!(mem.start & ~PHYS_MASK)); >> if ((mem.end - 1) & ~PHYS_MASK) >> mem.end &= PHYS_MASK; > I've changed this to > > assert(mem.end && !(mem.start & ~PHYS_MASK)); > mem.end &= PHYS_MASK; > > for v3. Looks good, Thanks, Alex
