Re: [PATCH] KVM: x86: Fix guest single-stepping while interruptible

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Oct 18, 2009 at 01:24:44PM +0200, Jan Kiszka wrote:
> Commit 705c5323 opened the doors of hell by unconditionally injecting
> single-step flags as long as guest_debug signaled this. This doesn't
> work when the guest branches into some interrupt or exception handler
> and triggers a vmexit with flag reloading.
> 
> Fix it by saving cs:rip when user space requests single-stepping and
> restricting the trace flag injection to this guest code position.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>
> ---
> 
>  arch/x86/include/asm/kvm_host.h |    4 +++
>  arch/x86/kvm/x86.c              |   47 +++++++++++++++++++++++----------------
>  2 files changed, 32 insertions(+), 19 deletions(-)

Applied, thanks.

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux