On Thu, Apr 22, 2021 at 08:59:50AM +0200, Paolo Bonzini wrote: > On 22/04/21 02:56, Ricardo Koller wrote: > > Copy arch/x86/include/asm/acpufeature.h and arch/x86/kvm/reverse_cpuid.h > > from the kernel so that KVM selftests can use them in the next commits. > > Also update the tools copy of arch/x86/include/asm/acpufeatures.h. > > Typo. > > > These should be kept in sync, ideally with the help of some script like > > check-headers.sh used by tools/perf/. > > Please provide such a script. > > Also, without an automated way to keep them in sync I think it's better to > copy all of them to tools/testing/selftests/kvm Will move them to the kvm subdir. The only issue is cpufeatures.h as that would create a third copy of it: there is one already at tools/arch/x86/include/asm/cpufeatures.h. Note that we can't move cpufeatures.h from tools/arch/x86/include/asm to tools/testing/selftests/kvm as it's already included by others like tools/perf. > so that we can be sure that > a maintainer (me) runs the script and keeps them up to date. I am fairly > sure that the x86 maintainers don't want to have anything to do with all of > this business! > > Paolo > Thanks for the review! I'll try this approach for the next version: copy the new headers to tools/testing/selftests/kvm (except cpufeatures.h), and add the script.
