Hi Drew,
On 4/7/21 7:59 PM, Andrew Jones wrote:
> If there's no virtio-console / chr-testdev configured, then the user
> probably didn't want them. Just silently fail rather than stating
> the obvious.
>
> Signed-off-by: Andrew Jones <drjones@xxxxxxxxxx>
> ---
> lib/chr-testdev.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/lib/chr-testdev.c b/lib/chr-testdev.c
> index 6890f63c8b29..b3c641a833fe 100644
> --- a/lib/chr-testdev.c
> +++ b/lib/chr-testdev.c
> @@ -54,11 +54,8 @@ void chr_testdev_init(void)
> int ret;
>
> vcon = virtio_bind(VIRTIO_ID_CONSOLE);
> - if (vcon == NULL) {
> - printf("%s: %s: can't find a virtio-console\n",
> - __func__, TESTDEV_NAME);
> + if (vcon == NULL)
Yes, please. This finally removes the warning when using kvmtool:
Reviewed-by: Alexandru Elisei <alexandru.elisei@xxxxxxx>
Thanks,
Alex
> return;
> - }
>
> ret = vcon->config->find_vqs(vcon, 2, vqs, NULL, io_names);
> if (ret < 0) {
