On Thu, Oct 15, 2009 at 05:08:16PM -0300, Marcelo Tosatti wrote: > On Thu, Oct 15, 2009 at 01:15:25PM -0400, Glauber Costa wrote: > > Hey, > > > > This patch is a proposal only. Among other things, it relies on a patch > > Juan is yet to send, and I also would want to give it a bit more testing. > > It shows my indented use of the new ioctl interface I've been proposing. > > > > First of all, we have to save the kvmclock msrs. This is per-cpu, and we > > were failing to do it so far. > > > > The ioctls are issued in pre-save and post-load sections of a new vmstate > > handler. I am not doing it in the cpu vmstate handler, because this has to > > be done once per VM, not cpu. What I basically do is to grab the time > > from GET ioctl, pass on through migration, and then do a SET on the other > > side. Should be straighforward. > > > > Please let me hear your thoughts. And don't get me started with this > > "you can't hear thoughts" thing! > > > > Otherwise looks good. > Also, note that, in vmstate table for kvmclock, I am using U64, instead of UINT64. This is unexistant on current qemu, I had to patch it. Juan said he's planning on sending it to qemu-devel today or tomorrow. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
