> -----邮件原件----- > 发件人: Jason Gunthorpe [mailto:jgg@xxxxxxxxxx] > 发送时间: 2021年4月10日 1:32 > 收件人: Alex Williamson <alex.williamson@xxxxxxxxxx> > 抄送: Zengtao (B) <prime.zeng@xxxxxxxxxxxxx>; cohuck@xxxxxxxxxx; > kvm@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; peterx@xxxxxxxxxx > 主题: Re: [PATCH v1 01/14] vfio: Create vfio_fs_type with inode per device > > On Fri, Apr 09, 2021 at 08:24:00AM -0600, Alex Williamson wrote: > > > > > #define DRIVER_VERSION "0.3" > > > > #define DRIVER_AUTHOR "Alex Williamson > <alex.williamson@xxxxxxxxxx>" > > > > #define DRIVER_DESC "VFIO - User Level meta-driver" > > > > > > > > +#define VFIO_MAGIC 0x5646494f /* "VFIO" */ > > > Move to include/uapi/linux/magic.h ? > > > > Hmm, yeah, I suppose it probably should go there. Thanks. > > From my review we haven't been doing that unless it is actually uapi relavent > for some reason (this is not) > Yes, it's not uapi relavent, and I still think it's better to put magic in a single header, and currently not all micros in magic.h are for uapi, some work should be done for that, but no ideas now, :) > In particular with CH having a patch series to eliminate all of these cases and > drop the constants.. > Interested, could you share the links for that? Thanks Zengtao > Jason
