On Fri, Apr 09, 2021 at 06:18:05PM +0100, Nikos Nikoleris wrote: > On 07/04/2021 19:59, Andrew Jones wrote: > > +exceptions_init: > > + mrc p15, 0, r2, c1, c0, 0 @ read SCTLR > > + bic r2, #CR_V @ SCTLR.V := 0 > > + mcr p15, 0, r2, c1, c0, 0 @ write SCTLR > > + ldr r2, =vector_table > > + mcr p15, 0, r2, c12, c0, 0 @ write VBAR > > + > > + mrs r2, cpsr > > + > > + /* > > + * Input r0 is the stack top, which is the exception stacks base > > Minor, feel free to ignore - wouldn't it be better to put this comment at > the start of this routine to inform the caller? Yes, that's a good suggestion. Will do for v2. > > I am not sure about the practical implications of having an .init section > but in any case, moving secondary_entry helper functions to .text seems > sensible. > > Reviewed-by Nikos Nikoleris <nikos.nikoleris@xxxxxxx> Thanks, drew
