Re: [PATCH 1/3] virtio: update reset callback to return status

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 4/7/2021 4:44 PM, Cornelia Huck wrote:
On Wed, 7 Apr 2021 12:09:22 +0000
Max Gurtovoy <mgurtovoy@xxxxxxxxxx> wrote:

The reset device operation, usually is an operation that might fail from
various reasons. For example, the controller might be in a bad state and
can't answer to any request. Usually, the paravirt SW based virtio
devices always succeed in reset operation but this is not the case for
HW based virtio devices.

This commit is also a preparation for adding a timeout mechanism for
resetting virtio devices.

Signed-off-by: Max Gurtovoy <mgurtovoy@xxxxxxxxxx>
---
  drivers/remoteproc/remoteproc_virtio.c |  3 ++-
  drivers/virtio/virtio.c                | 22 +++++++++++++++-------
  drivers/virtio/virtio_mmio.c           |  3 ++-
  drivers/virtio/virtio_pci_legacy.c     |  3 ++-
  drivers/virtio/virtio_pci_modern.c     |  3 ++-
  drivers/virtio/virtio_vdpa.c           |  3 ++-
  include/linux/virtio_config.h          |  5 +++--
  7 files changed, 28 insertions(+), 14 deletions(-)
You missed drivers/s390/virtio/virtio_ccw.c.

virtio_ccw_reset() should probably return -ENOMEM on allocation failure
and forward the return code of ccw_io_helper().

thanks, I found another 1-2 places that I missed. I'll update in v2.




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux