On Fri, Mar 26, 2021 at 02:29:56AM +0000, Tian, Kevin wrote: > > -int mdev_create_sysfs_files(struct mdev_device *mdev, struct mdev_type > > *type) > > +int mdev_create_sysfs_files(struct mdev_device *mdev) > > { > > struct kobject *kobj = &mdev->dev.kobj; > > What about adding a local "struct mdev_type *type" here? otherwise, Okay, saves two links in the diff Jason