Re: [PATCH v2 1/2] KVM: x86: hyper-v: Properly divide maybe-negative 'hv_clock->system_time' in compute_tsc_page_parameters()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v2 1/2] KVM: x86: hyper-v: Properly divide maybe-negative 'hv_clock->system_time' in compute_tsc_page_parameters()
From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Date: Wed, 31 Mar 2021 08:52:41 +0200
Cc: kvm@xxxxxxxxxxxxxxx, Sean Christopherson <seanjc@xxxxxxxxxx>, Wanpeng Li <wanpengli@xxxxxxxxxxx>, Jim Mattson <jmattson@xxxxxxxxxx>, Marcelo Tosatti <mtosatti@xxxxxxxxxx>
In-reply-to: <87a6qju97s.fsf@vitty.brq.redhat.com>
References: <20210329114800.164066-1-vkuznets@redhat.com> <20210329114800.164066-2-vkuznets@redhat.com> <20210330131236.GA5932@fuller.cnet> <87ft0cu2eq.fsf@vitty.brq.redhat.com> <4d7f375c-c912-fbeb-edd1-03d742d49dcb@redhat.com> <87a6qju97s.fsf@vitty.brq.redhat.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0

On 31/03/21 08:29, Vitaly Kuznetsov wrote:

I'm leaning towards making a v3 and depending on how complex it's going
to look like we can decide which way to go.

As you prefer, but I would have no problem with committing v2 for now.From the point of view of system_time being a signed delta your v2 isnot a regression.


Paolo

Follow-Ups:
- Re: [PATCH v2 1/2] KVM: x86: hyper-v: Properly divide maybe-negative 'hv_clock->system_time' in compute_tsc_page_parameters()
  - From: Vitaly Kuznetsov

References:
- [PATCH v2 0/2] KVM: x86: hyper-v: Fix TSC page update after KVM_SET_CLOCK(0) call
  - From: Vitaly Kuznetsov
- [PATCH v2 1/2] KVM: x86: hyper-v: Properly divide maybe-negative 'hv_clock->system_time' in compute_tsc_page_parameters()
  - From: Vitaly Kuznetsov
- Re: [PATCH v2 1/2] KVM: x86: hyper-v: Properly divide maybe-negative 'hv_clock->system_time' in compute_tsc_page_parameters()
  - From: Marcelo Tosatti
- Re: [PATCH v2 1/2] KVM: x86: hyper-v: Properly divide maybe-negative 'hv_clock->system_time' in compute_tsc_page_parameters()
  - From: Vitaly Kuznetsov
- Re: [PATCH v2 1/2] KVM: x86: hyper-v: Properly divide maybe-negative 'hv_clock->system_time' in compute_tsc_page_parameters()
  - From: Paolo Bonzini
- Re: [PATCH v2 1/2] KVM: x86: hyper-v: Properly divide maybe-negative 'hv_clock->system_time' in compute_tsc_page_parameters()
  - From: Vitaly Kuznetsov

Prev by Date: Re: [PATCH v3 05/25] x86/sgx: Introduce virtual EPC for use by KVM guests
Next by Date: Re: [PATCH 1/4] kvm: cpuid: adjust the returned nent field of kvm_cpuid2 for KVM_GET_SUPPORTED_CPUID and KVM_GET_EMULATED_CPUID
Previous by thread: Re: [PATCH v2 1/2] KVM: x86: hyper-v: Properly divide maybe-negative 'hv_clock->system_time' in compute_tsc_page_parameters()
Next by thread: Re: [PATCH v2 1/2] KVM: x86: hyper-v: Properly divide maybe-negative 'hv_clock->system_time' in compute_tsc_page_parameters()
Index(es):
- Date
- Thread

[Index of Archives] [KVM ARM] [KVM ia64] [KVM ppc] [Virtualization Tools] [Spice Development] [Libvirt] [Libvirt Users] [Linux USB Devel] [Linux Audio Users] [Yosemite Questions] [Linux Kernel] [Linux SCSI] [XFree86]