On 30/03/21 20:32, Ben Gardon wrote:
Patches 1-7 are x86 specific prep patches to play nice with moving
the hva->gfn memslot lookups into common code. There ended up being waaay
more of these than I expected/wanted, but I had a hell of a time getting
the flushing logic right when shuffling the memslot and address space
loops. In the end, I was more confident I got things correct by batching
the flushes.
Patch 8 moves the existing API prototypes into common code. It could
technically be dropped since the old APIs are gone in the end, but I
thought the switch to the new APIs would suck a bit less this way.
Patches 1-8 look good to me. Feel free to add my Reviewed-by tag to those.
I appreciate the care you took to make all those changes tiny and reviewable.
Just finished reviewing that part too, they were very nice and I've
queued them. I'll continue tomorrow with the rest.
Paolo