Re: [kvm-unit-tests PATCH v2 3/8] s390x: css: simplify skipping tests on no device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 29 Mar 2021 14:50:22 +0200
Pierre Morel <pmorel@xxxxxxxxxxxxx> wrote:

> On 3/29/21 10:19 AM, Thomas Huth wrote:
> > On 25/03/2021 10.39, Pierre Morel wrote:  
> >> We will lhave to test if a device is present for every tests
> >> in the future.
> >> Let's provide a macro to check if the device is present and
> >> to skip the tests if it is not.
> >>
> >> Signed-off-by: Pierre Morel <pmorel@xxxxxxxxxxxxx>
> >> ---
> >>   s390x/css.c | 27 +++++++++++----------------
> >>   1 file changed, 11 insertions(+), 16 deletions(-)

> > I wonder whether it would be easier to simply skip all tests in main() 
> > if the test device is not available, instead of checking it again and 
> > again and again...?
> > 
> >   Thomas
> >   
> 
> I will silently skip the remaining tests when the enumeration fails or 
> do you want that we see other information?
> It seems obvious enough that finding no device we do not continue testing.

Logging that the device enumeration failed should be enough info.





[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux