On 3/25/21 5:02 PM, Claudio Imbrenda wrote:
On Thu, 25 Mar 2021 10:39:05 +0100
Pierre Morel <pmorel@xxxxxxxxxxxxx> wrote:
...snip...
Trying to follow your comment, I have some questions:
+ /* 2- ORB address should be lower than 2G */
+ report_prefix_push("ORB Address above 2G");
+ expect_pgm_int();
+ ssch(test_device_sid, (void *)0x80000000);
another hardcoded address... you should try allocating memory over 2G,
and try to use it. put a check if there is enough memory, and skip if
you do not have enough memory, like you did below
How can I allocate memory above 2G?
+ check_pgm_int_code(PGM_INT_CODE_ADDRESSING);
+ report_prefix_pop();
+
+ /* 3- ORB address should be available we check 1G*/
+ top = get_ram_size();
+ report_prefix_push("ORB Address must be available");
+ if (top < 0x40000000) {
+ expect_pgm_int();
+ ssch(test_device_sid, (void *)0x40000000);
+ check_pgm_int_code(PGM_INT_CODE_ADDRESSING);
+ } else {
+ report_skip("guest started with more than 1G
memory");
this is what I meant above. you will need to run this test both with 1G
and with 3G of ram (look at the SCLP test, it has the same issue)
I do not understand, if I test with 3G RAM, I suppose that the framework
works right and I have my 3G RAM available.
Then I can check with an address under 1G and recheck with an address
above 1G.
What is the purpose to check with only 1G memory?
Regards,
Pierre
--
Pierre Morel
IBM Lab Boeblingen