On 3/26/21 9:41 AM, Janosch Frank wrote:
On 3/25/21 10:39 AM, Pierre Morel wrote:
We will lhave to test if a device is present for every tests
s/lhave/have/
yes
in the future.
Let's provide a macro to check if the device is present and
to skip the tests if it is not.
Signed-off-by: Pierre Morel <pmorel@xxxxxxxxxxxxx>
Reviewed-by: Janosch Frank <frankja@xxxxxxxxxxxxx>
Thanks
---
s390x/css.c | 27 +++++++++++----------------
1 file changed, 11 insertions(+), 16 deletions(-)
diff --git a/s390x/css.c b/s390x/css.c
index c340c53..16723f6 100644
--- a/s390x/css.c
+++ b/s390x/css.c
@@ -27,6 +27,13 @@ static int test_device_sid;
static struct senseid *senseid;
struct ccw1 *ccw;
+#define NODEV_SKIP(dev) do { \
s/device/schid/ ?
I have no strong opinions either way so choose what you like best.
can do it.
Also, since you use report(0, "") so often, maybe you want to introduce
report_fail() into the library in the future? The x86 vmx tests also use
report(0, "") a lot so you're not completely alone.
Could you please move the "do {" one line down so we start with a zero
indent?
OK
Thanks,
Pierre
--
Pierre Morel
IBM Lab Boeblingen
