> From: Christoph Hellwig <hch@xxxxxx> > Sent: Wednesday, March 24, 2021 3:21 AM > > > up_read(&parent->unreg_sem); > > - put_device(&mdev->dev); > > mdev_fail: > > > > > > > > - mdev_put_parent(parent); > > + put_device(&mdev->dev); > > That mdev_fail label is not very descriptive, what about free_device > instead? > There is only one goto to this place after this patch. Possibly just call it trylock_fail.
