On Wed, Mar 24, 2021 at 09:17:01AM -0700, Jacob Pan wrote: > I didn't mean the users of misc_cgroup will use css directly. I meant if I > want to use misc cgruop in ioasid.c, I have to do the following to avoid > undefined css: > #include <linux/cgroup.h> > #include <linux/misc_cgroup.h> > > So it might be simpler if you do #include <linux/cgroup.h> inside > misc_cgroup.h. Then in ioasid.c, I only need to do > #include <linux/misc_cgroup.h>. Sorry, I misunderstood the comment first time. I agree with you, I will add cgroup header file in the misc_cgroup.h after #ifdef CONFIG_CGROUP_MISC statement. Thanks Vipin