On Tue, Mar 23, 2021 at 02:55:24PM -0300, Jason Gunthorpe wrote: > struct mdev_type holds a pointer to the kref'd object struct mdev_parent, > but doesn't hold the kref. The lifetime of the parent becomes implicit > because parent_remove_sysfs_files() is supposed to remove all the access > before the parent can be freed, but this is very hard to reason about. > > Make it obviously correct by adding the missing get. Looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>