Re: [PATCH] KVM: X86: Fix missing local pCPU when executing wbinvd on all dirty pCPUs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/03/21 03:45, Wanpeng Li wrote:
From: Wanpeng Li <wanpengli@xxxxxxxxxxx>

We should execute wbinvd on all dirty pCPUs when guest wbinvd exits
to maintain datat consistency in order to deal with noncoherent DMA.
smp_call_function_many() does not execute the provided function on
the local core, this patch replaces it by on_each_cpu_mask().

Reported-by: Nadav Amit <namit@xxxxxxxxxx>
Cc: Nadav Amit <namit@xxxxxxxxxx>
Signed-off-by: Wanpeng Li <wanpengli@xxxxxxxxxxx>
---
  arch/x86/kvm/x86.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 012d5df..aa6d667 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -6638,7 +6638,7 @@ static int kvm_emulate_wbinvd_noskip(struct kvm_vcpu *vcpu)
  		int cpu = get_cpu();
cpumask_set_cpu(cpu, vcpu->arch.wbinvd_dirty_mask);
-		smp_call_function_many(vcpu->arch.wbinvd_dirty_mask,
+		on_each_cpu_mask(vcpu->arch.wbinvd_dirty_mask,
  				wbinvd_ipi, NULL, 1);
  		put_cpu();
  		cpumask_clear(vcpu->arch.wbinvd_dirty_mask);


Queued, thanks.

Paolo




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux