On Tue, Mar 16, 2021 at 08:09:19AM +0000, Tian, Kevin wrote:
> > From: Jason Gunthorpe <jgg@xxxxxxxxxx>
> > Sent: Saturday, March 13, 2021 8:56 AM
> >
> > mdev gets little benefit because it doesn't actually do anything, however
> > it is the last user, so move the code here for now.
>
> and indicate that vfio_add/del_group_dev is removed in this patch.
The "move the code here" (referring to the deleted functions) was
intended to cover that. I added some words:
mdev gets little benefit because it doesn't actually do anything, however
it is the last user, so move the vfio_init/register/unregister_group_dev()
code here for now.
> > diff --git a/drivers/vfio/mdev/vfio_mdev.c b/drivers/vfio/mdev/vfio_mdev.c
> > index b52eea128549ee..4469aaf31b56cb 100644
> > +++ b/drivers/vfio/mdev/vfio_mdev.c
> > @@ -21,6 +21,10 @@
> > #define DRIVER_AUTHOR "NVIDIA Corporation"
> > #define DRIVER_DESC "VFIO based driver for Mediated device"
> >
> > +struct mdev_vfio_device {
> > + struct vfio_device vdev;
> > +};
>
> following other vfio_XXX_device convention, what about calling it
> vfio_mdev_device? otherwise,
Right, but let's delete it as Alex suggests.
Jason
