On 16/03/21 18:52, Sean Christopherson wrote:
I don't
know that holding the fd instead of the kvm makes that much better though,
are there advantages to that I'm not seeing?
If there's no kvm pointer, it's much more difficult for someone to do the wrong
thing, and any such shenanigans stick out like a sore thumb in patches, which
makes reviewing future changes easier.
On the other hand holding the fd open complicates the code, reference
counting rules are already hard enough.
I think we only need a replacement for "mirror", what about "dependent"?
"is_dependent_enc_context" seems clear enough.
Paolo
