On Mon, Mar 15, 2021 at 08:07:46PM -0300, Jason Gunthorpe wrote: > So the goto unwind looks quite odd when this is open coded. At least > with the helpers you can read the init then uninit and go 'yah, OK, > this makes sense' Still looks odd to me. But this is your series and overall a major improvements, so: Reviewed-by: Christoph Hellwig <hch@xxxxxx>