Re: [PATCH v2 07/14] vfio/pci: Move VGA and VF initialization to functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 15, 2021 at 08:07:46PM -0300, Jason Gunthorpe wrote:
> So the goto unwind looks quite odd when this is open coded. At least
> with the helpers you can read the init then uninit and go 'yah, OK,
> this makes sense'

Still looks odd to me.  But this is your series and overall a major
improvements, so:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux