On Wed, Mar 10, 2021 at 08:30:01AM +0100, Christoph Hellwig wrote:
> > + ret = vfio_register_group_dev(&vdev->vdev);
> > if (ret) {
> > dev_err(dev, "VFIO_FSL_MC: Failed to add to vfio group\n");
> > - goto out_group_put;
> > + goto out_kfree;
> > }
> > + dev_set_drvdata(dev, vdev);
> >
> > + /*
> > + * FIXME: vfio_register_group_dev() allows VFIO_GROUP_GET_DEVICE_FD to
> > + * immediately return the device to userspace, but we haven't finished
> > + * setting it up yet.
> > + */
>
> This should be trivial to fix. Can you throw in a patch to move the
> vfio_register_group_dev later?
Hmm.. Yes I don't see an obvious reason why this couldn't be trivially
re-ordered.
I was hoping someone familiar with FSL would see this comment and say
if it is OK or not :)
I added a note to my list to make a followup in one of the later
cleaning series.
Jason
