> - ret = vfio_add_group_dev(&pdev->dev, &vfio_pci_ops, vdev); > + /* > + * FIXME: vfio_register_group_dev() allows VFIO_GROUP_GET_DEVICE_FD to > + * immediately return the device to userspace, but we haven't finished > + * setting it up yet. > + */ > + ret = vfio_register_group_dev(&vdev->vdev); Again, why not include a patch in the series to fix this up as well? The patch itself looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
