Re: [PATCH v2 05/17] KVM: x86/mmu: Allocate pae_root and lm_root pages in dedicated helper

Subject: Re: [PATCH v2 05/17] KVM: x86/mmu: Allocate pae_root and lm_root pages in dedicated helper
From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Date: Fri, 5 Mar 2021 18:34:23 +0100
Cc: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>, Wanpeng Li <wanpengli@xxxxxxxxxxx>, Jim Mattson <jmattson@xxxxxxxxxx>, Joerg Roedel <joro@xxxxxxxxxx>, kvm@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Ben Gardon <bgardon@xxxxxxxxxx>, Brijesh Singh <brijesh.singh@xxxxxxx>, Tom Lendacky <thomas.lendacky@xxxxxxx>
In-reply-to: <20210305011101.3597423-6-seanjc@google.com>
References: <20210305011101.3597423-1-seanjc@google.com> <20210305011101.3597423-6-seanjc@google.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0

On 05/03/21 02:10, Sean Christopherson wrote:

+	/*
+	 * This mess only works with 4-level paging and needs to be updated to
+	 * work with 5-level paging.
+	 */

Planning for this, it's probably a good idea to rename lm_root topml4_root. Can be done on top.


Paolo

References:
- [PATCH v2 00/17] KVM: x86/mmu: Lots of bug fixes
  - From: Sean Christopherson
- [PATCH v2 05/17] KVM: x86/mmu: Allocate pae_root and lm_root pages in dedicated helper
  - From: Sean Christopherson