Re: [PATCH 6/7] x86/boot/compressed/64: Check SEV encryption in 32-bit boot-path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 6/7] x86/boot/compressed/64: Check SEV encryption in 32-bit boot-path
From: Borislav Petkov <bp@xxxxxxxxx>
Date: Tue, 2 Mar 2021 20:43:53 +0100
Cc: x86@xxxxxxxxxx, Joerg Roedel <jroedel@xxxxxxx>, hpa@xxxxxxxxx, Andy Lutomirski <luto@xxxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Jiri Slaby <jslaby@xxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Tom Lendacky <thomas.lendacky@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, David Rientjes <rientjes@xxxxxxxxxx>, Cfir Cohen <cfir@xxxxxxxxxx>, Erdem Aktas <erdemaktas@xxxxxxxxxx>, Masami Hiramatsu <mhiramat@xxxxxxxxxx>, Mike Stunes <mstunes@xxxxxxxxxx>, Sean Christopherson <sean.j.christopherson@xxxxxxxxx>, Martin Radev <martin.b.radev@xxxxxxxxx>, Arvind Sankar <nivedita@xxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, kvm@xxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
In-reply-to: <20210210102135.30667-7-joro@8bytes.org>
References: <20210210102135.30667-1-joro@8bytes.org> <20210210102135.30667-7-joro@8bytes.org>

On Wed, Feb 10, 2021 at 11:21:34AM +0100, Joerg Roedel wrote:
> +	/*
> +	 * Store the sme_me_mask as an indicator that SEV is active. It will be
> +	 * set again in startup_64().

So why bother? Or does something needs it before that?

...

> +SYM_FUNC_START(sev_startup32_cbit_check)

s/sev_startup32_cbit_check/startup32_check_sev_cbit/

I guess.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

Follow-Ups:
- Re: [PATCH 6/7] x86/boot/compressed/64: Check SEV encryption in 32-bit boot-path
  - From: Joerg Roedel

References:
- [PATCH 0/7] x86/seves: Support 32-bit boot path and other updates
  - From: Joerg Roedel
- [PATCH 6/7] x86/boot/compressed/64: Check SEV encryption in 32-bit boot-path
  - From: Joerg Roedel

Prev by Date: Re: [PATCH] KVM: SVM: Clear the CR4 register on reset
Next by Date: Re: [PATCH] KVM: SVM: Clear the CR4 register on reset
Previous by thread: Re: [PATCH 6/7] x86/boot/compressed/64: Check SEV encryption in 32-bit boot-path
Next by thread: Re: [PATCH 6/7] x86/boot/compressed/64: Check SEV encryption in 32-bit boot-path
Index(es):
- Date
- Thread

[Index of Archives] [KVM ARM] [KVM ia64] [KVM ppc] [Virtualization Tools] [Spice Development] [Libvirt] [Libvirt Users] [Linux USB Devel] [Linux Audio Users] [Yosemite Questions] [Linux Kernel] [Linux SCSI] [XFree86]