Avi Kivity wrote: > On 10/08/2009 03:49 PM, Anthony Liguori wrote: >> Glauber Costa wrote: >>> This patch provides kvm with an in-kernel ioapic. We are currently >>> not enabling it. >>> The code is heavily based on what's in qemu-kvm.git. >> >> It really ought to be it's own file and own device model. Having the >> code mixed in with ioapic.c is confusing because it's unclear what >> code is in use when the in-kernel model is used. > > I disagree. It's the same device with the same guest-visible interface > and the same host-visible interface (save/restore, 'info ioapic' if we > write one). Splitting it into two files will only result in code > duplication. Shared functions can be pushed into a commonly used module (ioapic-common.c). And everyone touching it should realize then that it could affect more than one user. Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
