"Michael S. Tsirkin" <mst@xxxxxxxxxx> wrote: > Cirrus vga has a copy of many PCI macros, > and it doesn't even use them. Clean up. > @@ -3248,8 +3213,8 @@ static int pci_cirrus_vga_initfn(PCIDevice *dev) > /* setup PCI */ > pci_config_set_vendor_id(pci_conf, PCI_VENDOR_ID_CIRRUS); > pci_config_set_device_id(pci_conf, device_id); > + //pci_conf[0x04] = PCI_COMMAND_IOACCESS | PCI_COMMAND_MEMACCESS; If it is wrong as you claim in the other patch, just remove it, or at least put a comment. > pci_config_set_class(pci_conf, PCI_CLASS_DISPLAY_VGA); > - pci_conf[PCI_HEADER_TYPE] = PCI_HEADER_TYPE_NORMAL; Did yo;u wanted to remove this one also? > > /* setup memory space */ > /* memory #0 LFB */ Nice cleanup for the rest :) Later, Juan. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
