On Fri, 19 Feb 2021 18:38:39 +0100
Philippe Mathieu-Daudé <philmd@xxxxxxxxxx> wrote:
> Do not let 'query-machines' return machines not valid with
> the current accelerator.
>
> Suggested-by: Daniel Berrangé <berrange@xxxxxxxxxx>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
> ---
> hw/core/machine-qmp-cmds.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/hw/core/machine-qmp-cmds.c b/hw/core/machine-qmp-cmds.c
> index 44e979e503b..c8630bc2ddc 100644
> --- a/hw/core/machine-qmp-cmds.c
> +++ b/hw/core/machine-qmp-cmds.c
> @@ -204,6 +204,10 @@ MachineInfoList *qmp_query_machines(Error **errp)
> MachineClass *mc = el->data;
> MachineInfo *info;
>
> + if (!machine_class_valid_for_current_accelerator(mc)) {
> + continue;
> + }
> +
> info = g_malloc0(sizeof(*info));
> if (mc->is_default) {
> info->has_is_default = true;
Reviewed-by: Cornelia Huck <cohuck@xxxxxxxxxx>
