On 17/02/21 18:57, Sean Christopherson wrote:
That said, I'm also rusty on_why_ this code is needed. Why isn't it enough
to inject the exception normally, and let nested_vmx_check_exception decide
whether to inject a vmexit to L1 or an exception into L2?
Hmm, I suspect it was required at one point due to deficiencies elsewhere.
Handling this in the common fault handler logic does seem like the right
approach.
I think I'm going to merge a variant of patch 5 just to unbreak things.
But we should get rid of all this because after the exception payload
changes we shouldn't need it.
Paolo
Also, bonus question which should have been in the 5/7 changelog: are there
kvm-unit-tests testcases that fail with npt=0, and if not could we write
one? [Answer: the mode_switch testcase fails, but I haven't checked why].