On Tue, Feb 16, 2021, Dave Hansen wrote: > On 2/13/21 5:28 AM, Kai Huang wrote: > > arch/x86/kvm/vmx/sgx.c | 466 ++++++++++++++++++ > > arch/x86/kvm/vmx/sgx.h | 34 ++ > > Changes to these files won't hit the SGX MAINTAINERS entry if you run > get_maintainer.pl. That means Jarkko (and me, and the SGX mailing list) > probably won't get cc'd on changes here. > > Is that a bug or a feature? :) Feature. The stuff in those files is pure KVM, there's nothing interesting from an SGX subsystem persective. That's another reason to have sgx/virt.c, the stuff that does impact SGX can all go in there. The KVM SGX code is in split out because virtualizing ENCLS leafs takes a painful amount of code, and because SGX already has a separate Kconfig. Association with the SGX subsystem was a non-factor in that choice.
