On 2/10/21 1:04 AM, Guenter Roeck wrote:
On 2/9/21 4:27 PM, Waiman Long wrote:
[ ... ]
It is because in arch/mips/include/asm/spinlock.h, asm/qrwlock.h is included before asm/qspinlock.h. The compilation error should be gone if the asm/qrwlock.h is removed or moved after asm/qspinlock.h.
I did a x86 build and there was no compilation issue.
I can not really comment on what exactly is wrong - I don't know the code well
enough to do that - but I don't think this is a valid argument.
Anyway, it seems like mips is the only architecture affected by the problem.
I am not entirely sure, though - linux-next is too broken for that.
It does look like a rather common practice to include both qrwlock.h and
qspinlock.h in asm/spinlock.h file. I have just a patch to make sure
that qrwlock is always included after qspinlock.h if present. Hopefully
that can fix the compilation problem.
Cheers,
Longman
