Michael S. Tsirkin wrote: > On Wed, Oct 07, 2009 at 02:16:32PM +0200, Jan Kiszka wrote: >> Michael S. Tsirkin wrote: >>> Fix build with KVM_CAP_SET_GUEST_DEBUG: use QLIST macro >>> to declare list head. >>> >>> Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx> >>> --- >>> qemu-kvm.h | 2 +- >>> 1 files changed, 1 insertions(+), 1 deletions(-) >>> >>> diff --git a/qemu-kvm.h b/qemu-kvm.h >>> index 4523e25..d6748c7 100644 >>> --- a/qemu-kvm.h >>> +++ b/qemu-kvm.h >>> @@ -1229,7 +1229,7 @@ typedef struct KVMState { >>> int broken_set_mem_region; >>> int migration_log; >>> #ifdef KVM_CAP_SET_GUEST_DEBUG >>> - struct kvm_sw_breakpoint_head kvm_sw_breakpoints; >>> + QTAILQ_HEAD(, kvm_sw_breakpoint) kvm_sw_breakpoints; >>> #endif >>> struct kvm_context kvm_context; >>> } KVMState; >> If it's required here I bet we need this upstream too, right? > > No, upstream does not have qemu-kvm.h > All these files are qemu-kvm only. > upstream builds fine as is. Upstream has KVMState, too, but it also has a cleaner header structuring than qemu-kvm (as the latter is morphing towards to former). So yes, this is a qemu-kvm-only workaround. Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html