On 09.02.21 16:57, Thomas Huth wrote:
sizeof(somepointer) results in the size of the pointer, i.e. 8 on a 64-bit system, so the memcmp(data->ext_names[0], vm_name_ext, sizeof(vm_name_ext)) only compared the first 8 characters of the VM name here. Switch to a proper array to get the sizeof() right. Signed-off-by: Thomas Huth <thuth@xxxxxxxxxx> --- s390x/stsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/s390x/stsi.c b/s390x/stsi.c index 4109b8d..87d4804 100644 --- a/s390x/stsi.c +++ b/s390x/stsi.c @@ -106,7 +106,7 @@ static void test_3_2_2(void) 0x00, 0x03 }; /* EBCDIC for "KVM/" */ const uint8_t cpi_kvm[] = { 0xd2, 0xe5, 0xd4, 0x61 }; - const char *vm_name_ext = "kvm-unit-test"; + const char vm_name_ext[] = "kvm-unit-test"; struct stsi_322 *data = (void *)pagebuf;report_prefix_push("3.2.2");
Reviewed-by: David Hildenbrand <david@xxxxxxxxxx> -- Thanks, David / dhildenb
