On 2/8/21 11:23 PM, David Woodhouse wrote:
> From: David Woodhouse <dwmw@xxxxxxxxxxxx>
>
> This accidentally ended up locking and then immediately unlocking kvm->lock
> at the beginning of the function. Fix it.
>
> Fixes: a76b9641ad1c ("KVM: x86/xen: add KVM_XEN_HVM_SET_ATTR/KVM_XEN_HVM_GET_ATTR")
> Signed-off-by: David Woodhouse <dwmw@xxxxxxxxxxxx>
Reviewed-by: Joao Martins <joao.m.martins@xxxxxxxxxx>
> ---
> arch/x86/kvm/xen.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/x86/kvm/xen.c b/arch/x86/kvm/xen.c
> index 06fec10ffc4f..d8cdd84b1c0e 100644
> --- a/arch/x86/kvm/xen.c
> +++ b/arch/x86/kvm/xen.c
> @@ -105,8 +105,6 @@ int kvm_xen_hvm_set_attr(struct kvm *kvm, struct kvm_xen_hvm_attr *data)
>
> mutex_lock(&kvm->lock);
>
> - mutex_unlock(&kvm->lock);
> -
> switch (data->type) {
> case KVM_XEN_ATTR_TYPE_LONG_MODE:
> if (!IS_ENABLED(CONFIG_64BIT) && data->u.long_mode) {
>
