Re: [kvm-unit-tests PATCH v1 2/5] s390x: css: simplifications of the tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 2/2/21 6:29 PM, Thomas Huth wrote:
On 29/01/2021 15.34, Pierre Morel wrote:
In order to ease the writing of tests based on:
...snip...
  error_ccw:
      free_io_mem(senseid, sizeof(*senseid));
-error_senseid:
-    unregister_io_int_func(css_irq_io);
+    return retval;
+}

Maybe use "success" as a name for the variable instead of "retval"? ... since it's a boolean value...
yes, I do, thanks.
Pierre

--
Pierre Morel
IBM Lab Boeblingen



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux