Hi Amos, thanks for the fix! It is fine, but to avoid introducing
global statements, I've worked out another patch to fix that issue.
Also, there was another undefined variable lying around (base_path).
I've finished up the patch and sent it to the mailing list!
Cheers,
On Tue, Sep 22, 2009 at 11:32 PM, Amos Kong <akong@xxxxxxxxxx> wrote:
>
> Sorry for lost autotest@xxxxxxxxxxxxxxxx So send again. Thanks.
> ------------------------------------------------------
> fix an error of undefine variable
>
> 09/23 09:50:27 ERROR| traceback:0013| File "/usr/lib64/python2.4/logging/__init__.py", line 744, in emit
> 09/23 09:50:27 ERROR| traceback:0013| self.handleError(record)
> 09/23 09:50:27 ERROR| traceback:0013| File "/root/project/autotest/client/setup_modules.py", line 86, in _autotest_logging_handle_error
> 09/23 09:50:27 ERROR| traceback:0013| traceback.print_stack()
> 09/23 09:50:27 ERROR|setup_modu:0087| Future logging formatting exceptions disabled.
> 09/23 09:50:27 ERROR| kvm:0067| Test failed: global name 'root_module_name' is not defined
>
> Signed-off-by: Amos Kong <akong@xxxxxxxxxx>
> ---
> client/setup_modules.py | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/client/setup_modules.py b/client/setup_modules.py
> index dc255c4..8b3200b 100644
> --- a/client/setup_modules.py
> +++ b/client/setup_modules.py
> @@ -86,7 +86,7 @@ def _autotest_logging_handle_error(self, record):
> traceback.print_stack()
> sys.stderr.write('Future logging formatting exceptions disabled.\n')
>
> - if root_module_name == 'autotest_lib':
> + if global_root_module_name == 'autotest_lib':
> # Allow locally installed third party packages to be found
> # before any that are installed on the system itself when not.
> # running as a client.
> @@ -124,6 +124,8 @@ def setup(base_path, root_module_name=""):
> The setup must be different if you are running on an Autotest server
> or on a test machine that just has the client directories installed.
> """
> + global global_root_module_name
> + global_root_module_name = root_module_name
> # Hack... Any better ideas?
> if (root_module_name == 'autotest_lib.client' and
> os.path.exists(os.path.join(os.path.dirname(__file__),
> --
> 1.5.5.6
>
> _______________________________________________
> Autotest mailing list
> Autotest@xxxxxxxxxxxxxxx
> http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
>
--
Lucas
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
