On 1/12/21 12:55 PM, Halil Pasic wrote:
On Tue, 12 Jan 2021 02:12:51 +0100
Halil Pasic <pasic@xxxxxxxxxxxxx> wrote:
@@ -1347,8 +1437,11 @@ void vfio_ap_mdev_remove_queue(struct ap_device *apdev)
apqi = AP_QID_QUEUE(q->apqn);
vfio_ap_mdev_reset_queue(apid, apqi, 1);
- if (q->matrix_mdev)
+ if (q->matrix_mdev) {
+ matrix_mdev = q->matrix_mdev;
vfio_ap_mdev_unlink_queue(q);
+ vfio_ap_mdev_refresh_apcb(matrix_mdev);
+ }
kfree(q);
mutex_unlock(&matrix_dev->lock);
Shouldn't we first remove the queue from the APCB and then
reset? Sorry, I missed this one yesterday.
Yes, that's probably the order in which it should be done.
I'll change it.
Regards,
Halil
