Hi Marc,
This is a nice cleanup. Checked that the defines have the same value as the
constants they are replacing:
Reviewed-by: Alexandru Elisei <alexandru.elisei@xxxxxxx>
On 1/25/21 12:26 PM, Marc Zyngier wrote:
> Instead of using a bunch of magic numbers, use the existing definitions
> that have been added since 8673e02e58410 ("arm64: perf: Add support
> for ARMv8.5-PMU 64-bit counters")
>
> Signed-off-by: Marc Zyngier <maz@xxxxxxxxxx>
> ---
> arch/arm64/kvm/pmu-emul.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/kvm/pmu-emul.c b/arch/arm64/kvm/pmu-emul.c
> index 72cd704a8368..cb16ca2eee92 100644
> --- a/arch/arm64/kvm/pmu-emul.c
> +++ b/arch/arm64/kvm/pmu-emul.c
> @@ -23,11 +23,11 @@ static void kvm_pmu_stop_counter(struct kvm_vcpu *vcpu, struct kvm_pmc *pmc);
> static u32 kvm_pmu_event_mask(struct kvm *kvm)
> {
> switch (kvm->arch.pmuver) {
> - case 1: /* ARMv8.0 */
> + case ID_AA64DFR0_PMUVER_8_0:
> return GENMASK(9, 0);
> - case 4: /* ARMv8.1 */
> - case 5: /* ARMv8.4 */
> - case 6: /* ARMv8.5 */
> + case ID_AA64DFR0_PMUVER_8_1:
> + case ID_AA64DFR0_PMUVER_8_4:
> + case ID_AA64DFR0_PMUVER_8_5:
> return GENMASK(15, 0);
> default: /* Shouldn't be here, just for sanity */
> WARN_ONCE(1, "Unknown PMU version %d\n", kvm->arch.pmuver);
