On Tue, Jan 26, 2021 at 4:17 PM Jason Wang <jasowang@xxxxxxxxxx> wrote: > > > On 2021/1/19 下午1:07, Xie Yongji wrote: > > This patch introduces a dedicated workqueue for irq injection > > so that we are able to do some performance tuning for it. > > > > Signed-off-by: Xie Yongji <xieyongji@xxxxxxxxxxxxx> > > > If we want the split like this. > > It might be better to: > > 1) implement a simple irq injection on the ioctl context in patch 8 > 2) add the dedicated workqueue injection in this patch > > Since my understanding is that > > 1) the function looks more isolated for readers > 2) the difference between sysctl vs workqueue should be more obvious > than system wq vs dedicated wq > 3) a chance to describe why workqueue is needed in the commit log in > this patch > OK, I will try to do it in v4. Thanks, Yongji