On Thu, Jan 21, 2021 at 12:23:08PM +1300, Kai Huang wrote: > On Wed, 20 Jan 2021 13:50:12 +0200 Jarkko Sakkinen wrote: > > On Mon, Jan 18, 2021 at 04:26:49PM +1300, Kai Huang wrote: > > > From: Sean Christopherson <seanjc@xxxxxxxxxx> > > > > > > Add SGX1 and SGX2 feature flags, via CPUID.0x12.0x0.EAX, as scattered > > > features. As part of virtualizing SGX, KVM will expose the SGX CPUID > > > leafs to its guest, and to do so correctly needs to query hardware and > > > kernel support for SGX1 and SGX2. > > > > This commit message is missing reasoning behind scattered vs. own word. > > > > Please just document the reasoning, that's all. > > OK. Will do. How about: > > "Add SGX1 and SGX2 feature flags, via CPUID.0x12.0x0.EAX, as scattered > features, since adding a new leaf for only two bits would be wasteful." For *me*, that would be sufficient. /Jarkko
