Christoph Hellwig wrote:
On Thu, Oct 01, 2009 at 01:58:10PM +0200, Juan Quintela wrote:
Discused with Anthony about it. signalfd is complicated for qemu
upstream (too difficult to use properly), and eventfd ... The current
eventfd emulation is worse than the pipe code that it substitutes.
His suggestion here was to create a new abstraction with an API like:
push_notify()
pop_notify()
and then you can implement it with eventfd() pipes/whatever.
What was missing for you of compatfd: qemu_eventfd/qemu_signalfd?
Do a push_notify()/pop_notify() work for you?
I don't desperately want to use it myself anyway. I just want to get
rid of the highly annoyind spurious differences in the AIO code due
to use of compatfd. I would be perfectly fine with just killing this
use of eventfd in qemu-kvm.
That's what I'd suggest. The use of eventfd in qemu-kvm is wrong
because the compat function is not implemented correctly.
Regards,
Anthony Liguori
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
