On Tue, Jan 19, 2021 at 10:03:14AM -0800, Sean Christopherson wrote: > Doesn't adding making the SGX sub-features depend on X86_FEATURE_SGX have the > same net effect? Or am I misreading do_clear_cpu_cap()? No, you're correct - I missed that. > Though if we use the cpuid_deps table, I'd vote to get rid of clear_sgx_caps() > and call setup_clear_cpu_cap(X86_FEATURE_SGX) directly. And probably change the > existing SGX_LC behavior and drop clear_sgx_caps() in a separate patch instead > of squeezing it into this one. Yah, sounds good. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette