On 1/18/21 7:38 AM, Jiaxun Yang wrote: > From: Michael Forney <mforney@xxxxxxxxxxx> > > Prior to 2a4b472c3c, sys/signal.h was only included on OpenBSD > (apart from two .c files). The POSIX standard location for this > header is just <signal.h> and in fact, OpenBSD's signal.h includes > sys/signal.h itself. > > Unconditionally including <sys/signal.h> on musl causes warnings > for just about every source file: > > /usr/include/sys/signal.h:1:2: warning: #warning redirecting incorrect #include <sys/signal.h> to <signal.h> [-Wcpp] > 1 | #warning redirecting incorrect #include <sys/signal.h> to <signal.h> > | ^~~~~~~ > > Since there don't seem to be any platforms which require including > <sys/signal.h> in addition to <signal.h>, and some platforms like > Haiku lack it completely, just remove it. > > Tested building on OpenBSD after removing this include. > > Signed-off-by: Michael Forney <mforney@xxxxxxxxxxx> > Reviewed-by: Eric Blake <eblake@xxxxxxxxxx> > [jiaxun.yang@xxxxxxxxxxx: Move to meson] > Signed-off-by: Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx> > --- > meson.build | 1 - > include/qemu/osdep.h | 4 ---- > 2 files changed, 5 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
