On Thu, 14 Jan 2021 10:58:02 +1100 David Gibson <david@xxxxxxxxxxxxxxxxxxxxx> wrote: > When the "memory-encryption" property is set, we also disable KSM > merging for the guest, since it won't accomplish anything. > > We want that, but doing it in the property set function itself is > thereoretically incorrect, in the unlikely event of some configuration > environment that set the property then cleared it again before > constructing the guest. > > More importantly, it makes some other cleanups we want more difficult. > So, instead move this logic to machine_run_board_init() conditional on > the final value of the property. > > Signed-off-by: David Gibson <david@xxxxxxxxxxxxxxxxxxxxx> > Reviewed-by: Richard Henderson <richard.henderson@xxxxxxxxxx> > Reviewed-by: Greg Kurz <groug@xxxxxxxx> > --- > hw/core/machine.c | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) Reviewed-by: Cornelia Huck <cohuck@xxxxxxxxxx>